REF: Apply.apply_multiple #53362
Merged
REF: Apply.apply_multiple #53362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
May 24, 2023
pandas/core/apply.py
Outdated
| @@ -554,7 +561,20 @@ def apply_multiple(self) -> DataFrame | Series: | |||
| result: Series, DataFrame, or None | |||
| Result when self.f is a list-like or dict-like, None otherwise. | |||
| """ | |||
| return self.obj.aggregate(self.f, self.axis, *self.args, **self.kwargs) | |||
| if self.axis == 1 and isinstance(self.obj, ABCDataFrame): | |||
| return self.obj.T.apply(self.f, 0, *self.args, **self.kwargs).T | |||
There was a problem hiding this comment.
Needs to be args=self.args, not *self.args. Can you add a test here?
There was a problem hiding this comment.
Yeah, good catch. Done.
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
May 27, 2023
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards fixing #53325 (comment).
This avoids the need to call out into
(Series|DataFrame).aggregate. In a follow-up I will replace the use ofagg_(list|dict)_likewithapplyspecific versions of those methds or some similar solution, avoiding needing to callApply.aggfrom withinApply.apply_multiple.CC @rhshadrach